Both games have their ups and downs.
GH, I like how the charts look and the guitars are much better and easier to handle. Its easier to see the the circlular notes. (Just don't like the rectangular blocks in RB).
But Rockband has better music, larger variety in music, and a better drum set. The music in GH is really chosen based on how well the guitar is played in the song, hence the name Guitar Hero.